Skip to content

Reintroduce fleetctl as tool#13444

Open
endorama wants to merge 1 commit into
elastic:mainfrom
endorama:fleetctl-tool
Open

Reintroduce fleetctl as tool#13444
endorama wants to merge 1 commit into
elastic:mainfrom
endorama:fleetctl-tool

Conversation

@endorama

@endorama endorama commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

We recently removed fleetctl in #13440 as it's no longer used in test, and was part of systemtest.

But there is still use for it as a standalone tool to aid development and manual testing, so I'm proposing this PR that moves it in tools/

This change adds a direct dependency between tools and systemtest, but the same dependency was present, indirectly, before this PR so I don't consider it a blocker.

We may want to refactor systemtest/fleettest to split the concerns, but I'm not sure it's worth the effort at this moment.

@endorama endorama requested a review from a team as a code owner June 19, 2024 12:37
@mergify

mergify Bot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Jun 19, 2024
@endorama

Copy link
Copy Markdown
Contributor Author

I don't think we need to backport this PR.

@mergify

mergify Bot commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

This pull request is now in conflicts. Could you fix it @endorama? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fleetctl-tool upstream/fleetctl-tool
git merge upstream/main
git push upstream fleetctl-tool

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 10, 2024
@mergify mergify Bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@v1v v1v added the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
@mergify mergify Bot removed the backport-skip Skip notification from the automated backport with mergify label Sep 10, 2024
isaacaflores2
isaacaflores2 previously approved these changes Jun 27, 2025

@isaacaflores2 isaacaflores2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks did would have been helpful for some recent configs we added to the integrations package

@mergify

mergify Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

This pull request is now in conflicts. Could you fix it @endorama? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fleetctl-tool upstream/fleetctl-tool
git merge upstream/main
git push upstream fleetctl-tool

removed in elastic#13440 from systemtests
but still can be useful for development or manual testing purposes
@prodsecmachine

prodsecmachine commented Jun 4, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@endorama

endorama commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

removed unnecessary commits, rebased onto main.

@endorama endorama enabled auto-merge June 4, 2026 08:00
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants