Repository navigation
Unify header and footer language menu styles - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header and footer language menus had different icon sizes, fonts, spacing, menu surfaces and active states. Use one shared LanguageMenu component for both locations, including the current-language label and consistent focus/hover styles. Keep the header menu opening down and the footer menu opening up.
Scope header navigation link rules to direct children so they cannot override language menu options. Preserve the current page when changing language.
Validation: catalog tests, Astro check, production build, and browser comparison of computed typography, colors, spacing and link destinations in both menu instances.