Implement bounded ordered print-interior PDF generation (#416) - #432
Merged
Merged
Conversation
Pull Request Summary by devActivityMetricsAchievements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publication.generate.pdf.interiorroute from an immutable, ordered PNG or JPEG collection to one print-interior PDF. Require explicit uniform trim/bleed geometry, a pinned and observed img2pdf 0.6.3 provider, direct bounded argv, and a required interior target.Local validation
cargo test --workspace --locked --quietwith real img2pdf 0.6.3: 1,210 passed, 11 ignored, 0 failed. Synthetic route tests include PNG and JPEG clean-build determinism, a 44-page recipe, source/refusal cases, provider failures, and in-flight cancellation.cargo clippy --workspace --all-targets --locked -- -D warningscargo fmt --all --checkrenderflow spec schemamatches the checked-in JSON Schema; strict MkDocs build passed.build --dry-runandbuildproduced one validated PDF from synthetic pages.6b080da6c2dee3c46ac504334f3fa034366ee2a6matches the locally validated tree exactly.No real publication pages were processed. Print/retailer acceptance and calibrated color reproduction are outside this bounded route.
Closes #416