Repository navigation
test: verify fenced retries and complete job conservation - #192
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test oracles rejected valid queue behavior: chaos accounting omitted delayed retries, and the PostgreSQL public Worker test treated an applied failure/retry as duplicate processing. The tests now check every original ID across all states and require fenced per-attempt delivery histories with exactly one durable completion.
Real SQLite and PostgreSQL regressions prove both counterexamples. The race suite retains all 18 original cases, with three additional regressions; the delivery checker has 19 rejection cases and two acceptance cases. Runtime and retry/lease settings are unchanged. The specific historical PostgreSQL CI cause remains unclassified because its original logs lacked per-attempt evidence; unexplained repeats still fail.
Type of change
Compatibility
Tests and documentation only. Public APIs, protocols, schemas and runtime scheduling/retry/lease settings are unchanged; no migration.
How was this tested?
Validation on executable tree
e2c50d57:Full parallel sandbox: unit 11,931 pass / 0 fail / 404 skip, TCP 553 / 0, embedded 349 / 0; no errors or resource anomalies.
Fresh Ubuntu 24.04 arm64 Machine: unit 12,062 / 0 / 404, TCP 553 / 0, embedded 349 / 0, tinyfs 9 / 0, typecheck and format passed; logs copied and Machine deleted.
Complete PostgreSQL 16.16, 17.12 and 18.7 suites: each 571 pass / 0 fail / 1 opt-in soak skip.
Later changes affect only the changelog and work-state evidence;
gate-delta.shclassifies the delta as documentation only.Added or updated tests; real persistence reproductions fail with the old oracles.
bun run test:sandboxpasses.Standalone
test:modelandtest:sandbox:sdkare not triggered by this test/documentation change; both queue/workflow models also pass inside the full unit gate.Checklist
docs/updated.docs/src/content/docs/changelog.mdupdated.