Generate amalgamation on releases - #31
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new release workflow interpolates the tag directly into shell commands/filenames, which can lead to unsafe evaluation and path issues unless the tag is passed safely (e.g., via env vars and sanitization/escaping).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a version string to the primer CLI and introduces a GitHub Actions workflow to generate and upload an amalgamated primer script as a release asset when a GitHub Release is published.
Changes:
- Add
PRIMER_VERSIONand surface it in--helpoutput plus a new-V/--versionflag. - Add a
Releaseworkflow that builds an amalgamatedprimer-<tag>.shand uploads it to the GitHub Release.
File summaries
| File | Description |
|---|---|
primer |
Introduces PRIMER_VERSION, prints version in help output, and adds -V/--version. |
.github/workflows/release.yml |
Adds a release-published workflow to build and upload an amalgamated primer release asset. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.