Add support for Fedora - #28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated user creation logic in libexec/auth.sh can regress Debian/Ubuntu behavior, and the dnf wrapper currently suppresses stderr even in debug mode, reducing diagnosability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds Fedora support across Primer’s OS/package/network abstractions and related steps, while also addressing a few usability/compatibility bugs in host/user handling.
Changes:
- Add Fedora support to OS update/upgrade/package operations (dnf) and network dependency resolution (iproute).
- Update steps to better support Fedora (timezone handling, machinery Tcl deps, Docker package guessing).
- Fix hostname resolution and users/auth option/behavior issues (e.g.,
--extparsing, group membership command usage).
File summaries
| File | Description |
|---|---|
primer |
Switch hostname reporting/token substitution to primer_net_hostname for consistency/portability. |
libexec/steps/users.sh |
Fix --ext option assignment and add --groups option wiring. |
libexec/steps/timezone.sh |
Treat Fedora like Debian/Ubuntu for tzdata + /etc/localtime symlink approach. |
libexec/steps/machinery.sh |
Add Fedora-specific Tcl dependency list for machinery install. |
libexec/steps/docker.sh |
Expand Docker package candidates (incl. moby-engine) and add trace logging during detection. |
libexec/os.sh |
Implement Fedora flows for update/upgrade/install/remove/list/search and add a dnf wrapper. |
libexec/net.sh |
Add distro-aware ip dependency installation and introduce primer_net_hostname. |
libexec/auth.sh |
Adjust group membership command selection and reorder user creation paths (now preferring useradd). |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition: