Repository navigation
feat: add Python 3.12 support and drop Python 3.8 - #1
Open
hiteshkava wants to merge 3 commits into
Open
hiteshkava wants to merge 3 commits into
hiteshkava wants to merge 3 commits into
Conversation
naincy128
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked from openedx/xqueue-watcher#120 ("chore: drop Python 3.11 support"), following the same pattern used for the
xqueuePython 3.12 upgrade (edx/xqueue#3). Our fork was sitting exactly at the state right before upstream openedx#120 (CI matrix['3.11', '3.12'],common_constraints.txtmatching pre-openedx#120 exactly), so the cherry-pick applied cleanly.Changes
.github/workflows/ci.ymlpython-version: ['3.11', '3.12']→['3.12']requirements/common_constraints.txtDjango<5.0→Django<6.0; removedpip<24.3andurllib3<2.3.0pinsrequirements/*.txt(base, ci, pip, pip_tools, production, test)make upgrade)setup.pyversion='0.4'→'1.0.0'Out of scope
The repo's own
Dockerfile(still Ubuntu 16.04 Xenial + Python 2) is untouched — production deploys via the AMI/AnsiblexqwatcherGoCD pipeline, not Docker, and this Dockerfile appears unused.Testing
pytest: 24/25 pass. The one failure (test_jailed_grader.py::test_correct) is a pre-existing environment gap (codejail/apparmor sandbox not configured in this dev container) — reproduced identically on Python 3.11 with the original, pre-upgrade requirements, confirming it's not a Python 3.12 regression.client,grader,jailedgrader,manager,settings) import cleanly under Python 3.12.3, and the CLI entrypoint (python -m xqueue_watcher -d <config_root>) starts up without error.jailedgrader.py's use ofSourceFileLoader.load_module()— triggers aDeprecationWarningunder 3.12 but still functions; not a current blocker, worth a follow-up to migrate toexec_module().Related
configurationrole update: feat: upgrade xqwatcher to Python 3.12 configuration#387 — adds the Jammy/Python 3.12 install task this role was previously missing entirelyedx-internalAMI pipeline bump: https://github.com/edx/edx-internal/pull/14969 —gocd/manually-created-pipelines/xqwatcher.yamlUbuntu 20.04 → 22.04, plus the per-coursePYTHON_EXECUTABLE/numpypin updatesMITx-7.QBWx,MITx-6.00x) still need their own verification against MIT's private grader repos — seeedx-internal#14969for the numpy/Python-version details on that