Skip to content

chore: cleaning up jenkins jobs - #379

Merged
phaneendra-reddy-g merged 1 commit into
masterfrom
phaneendra/GSRE-2681
Sep 10, 2026
Merged

chore: cleaning up jenkins jobs#379
phaneendra-reddy-g merged 1 commit into
masterfrom
phaneendra/GSRE-2681

Conversation

@phaneendra-reddy-g

@phaneendra-reddy-g phaneendra-reddy-g commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

https://2u-internal.atlassian.net/browse/GSRE-2681

Summary:

  • cleaning up the Jenkins job config as part of containerization post-migration.

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The PR title/description describe Jenkins job config cleanup, but the changes shown remove lifecycle/retirement tooling instead, so the PR metadata/scope should be aligned before merge.

Pull request overview

This PR removes legacy AWS autoscaling lifecycle/host-retirement automation artifacts from the configuration repo, likely as part of post-migration cleanup of operational workflows.

Changes:

  • Deletes the asg_lifcycle_watcher.py SQS/ASG lifecycle watcher utility.
  • Removes the retire_host.yml Ansible playbook used for retirement workflows/log sync/minos verification.
  • Removes the lifecycle_inventory.py dynamic Ansible inventory script based on ASG instance lifecycle state.
File summaries
File Description
util/vpc-tools/asg_lifcycle_watcher.py Removes the ASG lifecycle watcher script that processed SQS lifecycle events.
playbooks/retire_host.yml Removes the Ansible playbook used for host retirement actions and verification steps.
playbooks/lifecycle_inventory.py Removes the dynamic inventory generator that grouped instances by ASG lifecycle state.
Review details

Suppressed comments (1)

playbooks/retire_host.yml:1

  • The PR title/description indicate a Jenkins job config cleanup, but this change deletes a host-retirement playbook (and related lifecycle tooling) rather than updating Jenkins job configuration. Please align the PR title/description with the actual change (decommissioning these retirement tools) or include the intended Jenkins job config changes so reviewers can validate the correct scope.
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@phaneendra-reddy-g
phaneendra-reddy-g merged commit b2a5097 into master Sep 10, 2026
4 checks passed
@phaneendra-reddy-g
phaneendra-reddy-g deleted the phaneendra/GSRE-2681 branch September 10, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants