Skip to content

-- alter repeat "--begin <value> --end <value> --current <value>" ECFLOW-1852 - #482

Open
marcosbento wants to merge 4 commits into
developfrom
task/alter_begin_end
Open

marcosbento wants to merge 4 commits into
developfrom
task/alter_begin_end

Conversation

@marcosbento

@marcosbento marcosbento commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Description

As per PR title -- see commit messages for details.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-482

Cover every Repeat kind, Node::changeRepeat, and --alter change repeat
through the server, persistence, incremental sync, the CLI and Python.

Re ECFLOW-1852
@codecov-commenter

codecov-commenter commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.92587% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.33%. Comparing base (e3d738c) to head (e053955).

Files with missing lines Patch % Lines
libs/node/test/parser/TestRepeatPersistence.cpp 99.36% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
+ Coverage    56.69%   57.33%   +0.63%     
===========================================
  Files         1265     1271       +6     
  Lines       105999   107289    +1290     
  Branches     15403    15417      +14     
===========================================
+ Hits         60101    61512    +1411     
+ Misses       45898    45777     -121     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pin how Repeats are created, persisted, reloaded, synchronised and
iterated at their limits, known defects included, so that the coming
changes start from the current behaviour.

Re ECFLOW-1852
Set <name>_DOW to <invalid>, as the other derived variables, once a
repeat date or datelist is past its end.

Re ECFLOW-1852
Check the ordering and range, and clamp the value, of date, datetime
and integer Repeats through one helper, so that changes of begin, end
and step can reuse it. No change of behaviour.

Re ECFLOW-1852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants