Repository navigation
Conversation
joobog
force-pushed
the
feature/increase_sh_coverage
branch
from
October 9, 2026 18:13
02830a6 to
09cd656
Compare
Contributor
|
We already have a test file for grib_dump -D Why not put this test in there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new test loop to
tests/grib_dump.shto ensure thegrib_dumptool runs on thesh_pl_grib2.tmplsample file if it exists. This improves test coverage for the SH accessor.Contributor Declaration
By opening this pull request, I affirm the following: