Skip to content

Increase SH code coverage - #599

Open
joobog wants to merge 1 commit into
developfrom
feature/increase_sh_coverage
Open

joobog wants to merge 1 commit into
developfrom
feature/increase_sh_coverage

Conversation

@joobog

@joobog joobog commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Description

This pull request adds a new test loop to tests/grib_dump.sh to ensure the grib_dump tool runs on the sh_pl_grib2.tmpl sample file if it exists. This improves test coverage for the SH accessor.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@joobog
joobog force-pushed the feature/increase_sh_coverage branch from 02830a6 to 09cd656 Compare October 9, 2026 18:13
@sawom666

sawom666 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

We already have a test file for grib_dump -D
See
tests/grib_dump_debug.sh

Why not put this test in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants