Skip to content

Ensure correct url is returned when running in github actions - #50

Merged
wdeconinck merged 1 commit into
ecmwf:developfrom
prgillies:fix_remote_url_in_gh_actions
Sep 15, 2026
Merged

wdeconinck merged 1 commit into
ecmwf:developfrom
prgillies:fix_remote_url_in_gh_actions

Conversation

@prgillies

Copy link
Copy Markdown
Contributor

Description

In GitHub Actions, Git authentication configuration can rewrite GitHub remote URLs to include credentials. On a reused checkout, ecbundle’s multi-remote functionality obtains the rewritten URL via git remote and compares it literally with the unauthenticated URL from the bundle. It therefore treats the existing remote as different and fails while adding or updating remotes. This PR reads the remote URL directly from Git configuration, avoiding URL rewriting during comparison and allowing builds to be rerun using existing checkouts.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.22%. Comparing base (de8a72c) to head (aff747e).

Files with missing lines Patch % Lines
ecbundle/git.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   49.20%   49.22%   +0.01%     
==========================================
  Files          51       51              
  Lines       10385    10394       +9     
==========================================
+ Hits         5110     5116       +6     
- Misses       5275     5278       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prgillies

Copy link
Copy Markdown
Contributor Author

fyi @wdeconinck (not sure if you get notifications and can't add reviewers)

@prgillies
prgillies changed the base branch from main to develop September 15, 2026 10:11

@wdeconinck wdeconinck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great @prgillies good change!

@wdeconinck
wdeconinck merged commit 3ba2b4c into ecmwf:develop Sep 15, 2026
4 checks passed
wdeconinck added a commit that referenced this pull request Sep 25, 2026
* release/2.6.0:
  Version 2.6.0
  Add ecbundle-merge to setup.py scripts (#51)
  Ensure correct url is returned when running in github actions (#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants