Repository navigation
Ensure correct url is returned when running in github actions - #50
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 49.20% 49.22% +0.01%
==========================================
Files 51 51
Lines 10385 10394 +9
==========================================
+ Hits 5110 5116 +6
- Misses 5275 5278 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
fyi @wdeconinck (not sure if you get notifications and can't add reviewers) |
wdeconinck
approved these changes
Sep 15, 2026
wdeconinck
left a comment
Member
There was a problem hiding this comment.
That looks great @prgillies good change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In GitHub Actions, Git authentication configuration can rewrite GitHub remote URLs to include credentials. On a reused checkout, ecbundle’s multi-remote functionality obtains the rewritten URL via git remote and compares it literally with the unauthenticated URL from the bundle. It therefore treats the existing remote as different and fails while adding or updating remotes. This PR reads the remote URL directly from Git configuration, avoiding URL rewriting during comparison and allowing builds to be rerun using existing checkouts.
Contributor Declaration
By opening this pull request, I affirm the following: