fix: handle null address in NioTransport.convert to avoid NPE - #6334
Closed
waterWang wants to merge 1 commit into
Closed
fix: handle null address in NioTransport.convert to avoid NPE#6334waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
DatagramChannel.localAddress() can return null when the channel is not bound. Passing null to NioTransport.convert(SocketAddress) causes an NPE in isUnixDomainSocketAddress because it calls address.getClass(). Other transports (Epoll/KQueue) safely return null for non-InetSocketAddress via instanceof checks, so align NioTransport by returning null for null input. Fixes eclipse-vertx#6333
Member
|
Superseded by #6335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6333
DatagramChannel.localAddress()returns null when the channel is not bound, and passing null toNioTransport.convert(SocketAddress)causes a NullPointerException inisUnixDomainSocketAddress(which callsaddress.getClass()).Epoll/KQueue transports already handle this safely via
instanceofchecks (returning null for non-InetSocketAddress). This aligns NioTransport by returning null for null input.