Add a ChunkedWriteHandler when a socket is upgraded to SSL - #6332
Open
doxlik wants to merge 1 commit into
Open
Conversation
The ChunkedWriteHandler is installed once when the pipeline is created and only when the channel is encrypted at that point, whereas supportsFileRegion() is evaluated at write time against the live pipeline. A socket upgraded with upgradeToSsl() therefore stops using the file region transfer without gaining the handler that consumes the chunked file NetSocket#sendFile writes: the ChunkedNioFile reaches the tail of the pipeline and Netty rejects it with an UnsupportedMessageTypeException, the future fails and the peer receives no data. Install the handler when the upgrade completes, unless the pipeline already has one. It is added before the connection handler so that the chunks are written to the SSL handler and encrypted, which is where the pipeline places it when the channel is created encrypted. Signed-off-by: doxlik <doxlikx@gmail.com>
Author
|
@vietj please have a look once you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ChunkedWriteHandler is installed once when the pipeline is created and only when the channel is encrypted at that point, whereas supportsFileRegion() is evaluated at write time against the live pipeline. A socket upgraded with upgradeToSsl() therefore stops using the file region transfer without gaining the handler that consumes the chunked file NetSocket#sendFile writes: the ChunkedNioFile reaches the tail of the pipeline and Netty rejects it with an UnsupportedMessageTypeException, the future fails and the peer receives no data.
Install the handler when the upgrade completes, unless the pipeline already has one. It is
inserted before the connection handler, so that the chunks it produces are written through the
SSL handler and encrypted. This is the position the pipeline gives it when the channel is
created encrypted.
Closes #6331