Skip to content

Usubscription v4 - #358

Open
AnotherDaniel wants to merge 1 commit into
eclipse-uprotocol:mainfrom
etas-contrib:usubscription_v4
Open

AnotherDaniel wants to merge 1 commit into
eclipse-uprotocol:mainfrom
etas-contrib:usubscription_v4

Conversation

@AnotherDaniel

Copy link
Copy Markdown
Contributor
  • implement all changes required to support usubscription spec v4
  • some dependency version bumps

Comment thread Cargo.toml
Comment thread src/core/usubscription/usubscription_server.rs Outdated
Comment thread src/core/usubscription/usubscription_server.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/communication.rs Outdated
@sophokles73

Copy link
Copy Markdown
Contributor

@AnotherDaniel I have put most (if not all) of your proposed crate updates into a separate PR (#362). Can you take a look, approve and then rebase this PR?

@sophokles73

Copy link
Copy Markdown
Contributor

@AnotherDaniel can you also resolve the conflicts with main?

Comment thread Cargo.toml Outdated
@AnotherDaniel AnotherDaniel reopened this Aug 25, 2026
@AnotherDaniel AnotherDaniel self-assigned this Aug 26, 2026
@AnotherDaniel AnotherDaniel added enhancement New feature or request breaking change This pull request introduces a change to public API which is not backwards compatible labels Aug 26, 2026
Comment thread src/communication.rs Outdated
Comment thread src/communication/pubsub.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription/usubscription_proto.rs Outdated
Comment thread src/core/usubscription/usubscription_client.rs Outdated
Comment thread examples/usubscription_server.rs Outdated
@sophokles73

Copy link
Copy Markdown
Contributor

It seems like you didn't push any of the changes that you mentioned in the comments ...

@AnotherDaniel

Copy link
Copy Markdown
Contributor Author

It seems like you didn't push any of the changes that you mentioned in the comments ...

Yes, you're right. git mishap - should be back now.

Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription.rs
Comment thread src/core/usubscription.rs Outdated
Comment thread src/core/usubscription/usubscription_client.rs Outdated
Comment thread src/core/usubscription/usubscription_server.rs Outdated
Comment thread src/core/usubscription/usubscription_proto.rs
Comment thread src/core/usubscription/usubscription_proto.rs
Comment thread src/core/usubscription/usubscription_client.rs Outdated

@sophokles73 sophokles73 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73

Copy link
Copy Markdown
Contributor

Can you rebase this, i.e. not merge the main branch into this PR ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This pull request introduces a change to public API which is not backwards compatible enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants