Change detection in footnotes between main and compare plannings#2513
Draft
mariusheine wants to merge 1 commit into
Draft
Change detection in footnotes between main and compare plannings#2513mariusheine wants to merge 1 commit into
mariusheine wants to merge 1 commit into
Conversation
Test Results23 tests - 113 23 ✅ - 113 0s ⏱️ - 8m 32s Results for commit 9cf3ad8. ± Comparison against base commit 9b7e5d8. This pull request removes 113 tests. |
Comment on lines
+463
to
+470
| static def Iterable<FootnoteInfo> getFootnoteInfos( | ||
| FootnoteContainer fnContainer) { | ||
| return switch (fnContainer) { | ||
| SimpleFootnoteContainer: fnContainer.footnoteInfos | ||
| CompareFootnoteContainer: fnContainer.footnoteInfos | ||
| default: #[] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@mariusheine you can create for each type of FootnoteContainer a `dispatch`` function, then you no need this switch case here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.