Skip to content

CLI Subscribe fixes - #65

Merged
lukasmittag merged 2 commits into
eclipse-kuksa:mainfrom
HHN:fix/cli_v2
Aug 26, 2026
Merged

lukasmittag merged 2 commits into
eclipse-kuksa:mainfrom
HHN:fix/cli_v2

Conversation

@SebastianSchildt

@SebastianSchildt SebastianSchildt commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

This fixes some issues in the CLI tool (does not touch API code itself)

Issues fixed:

  • V2 API does not accept wildcards, therefore wildcard/branch subscribes did not work with a v2 API databroker. This is fixed by also adding wildcard expansion similar as we already have in the getValue path
  • subscribeMultiple had severly broken v1/v2 routing logic. Also it was a weird command. Instead now the nromal subscribe CLI command can optionally also accept multiple paths

To test

  • start current databroker i.e. docker run -it --rm --net=host ghcr.io/eclipse-kuksa/kuksa-databroker:0.7 --port 55558
  • start old client, i.e. docker run --rm -it --net=host ghcr.io/eclipse-kuksa/kuksa-python-sdk/kuksa-client:main grpc://<your_host_ip>:55558
    • do sth like subscribe Vehicle.ADAS.** or subscribe Vehicle.Chassis and see it doesn't work
  • start version from this PR (i.e. with checkout pip install, or build docker locally first like docker build -t kctest -f kuksa-client/Dockerfile .
    • do sth like subscribe Vehicle.ADAS.** or subscribe Vehicle.Chassis , do some setValue and see it works now

Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
@SebastianSchildt
SebastianSchildt marked this pull request as ready for review August 26, 2026 07:11
@nayakned
nayakned self-requested a review August 26, 2026 11:05
@nayakned

Copy link
Copy Markdown
Contributor

Tested. Found working as described.

@lukasmittag lukasmittag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we thread subscribe call with multiple args to subscribe multiple via overloading the function arguments to not break api but keep aligned with cli calls?

@SebastianSchildt

Copy link
Copy Markdown
Contributor Author

This API/SDK gotten to be a big mess and is due for some serious rewrite/redesign... But I think it is fine.

If you use subscribe_current_values([...]) from grpc API (not CLI) it works as the fix in #59 actually introduced the "fallback/extend" magic

If using the lower level subscribe(entries=[SubscribeEntry(...)])(called "full-fledged API in docs), well... that does not support v2 so will always use v1 (which does expansion databroker side)

I guess we would still need to repair subscribe_target_values([...]).... but maybe not here. It was broken before, I did not break it....

05onfire1_xp-superJumbo-v2

@lukasmittag

Copy link
Copy Markdown
Contributor

Ahh I see the function is in the backend - so not exposed over sdk so my worries were unnecessary. I agree with the meme :)

@lukasmittag lukasmittag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmittag
lukasmittag merged commit 08a6ec5 into eclipse-kuksa:main Aug 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants