CLI Subscribe fixes - #65
Conversation
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
22a7b7d to
02f76f7
Compare
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
02f76f7 to
6ae573a
Compare
|
Tested. Found working as described. |
lukasmittag
left a comment
There was a problem hiding this comment.
should we thread subscribe call with multiple args to subscribe multiple via overloading the function arguments to not break api but keep aligned with cli calls?
|
This API/SDK gotten to be a big mess and is due for some serious rewrite/redesign... But I think it is fine. If you use If using the lower level I guess we would still need to repair
|
|
Ahh I see the function is in the backend - so not exposed over sdk so my worries were unnecessary. I agree with the meme :) |

This fixes some issues in the CLI tool (does not touch API code itself)
Issues fixed:
To test
docker run -it --rm --net=host ghcr.io/eclipse-kuksa/kuksa-databroker:0.7 --port 55558docker run --rm -it --net=host ghcr.io/eclipse-kuksa/kuksa-python-sdk/kuksa-client:main grpc://<your_host_ip>:55558subscribe Vehicle.ADAS.**orsubscribe Vehicle.Chassisand see it doesn't workdocker build -t kctest -f kuksa-client/Dockerfile .subscribe Vehicle.ADAS.**orsubscribe Vehicle.Chassis, do somesetValueand see it works now