Fix target group assignment with RSQL negation filters (e.g. tag!=tag…#3116
Open
strailov wants to merge 3 commits into
Open
Fix target group assignment with RSQL negation filters (e.g. tag!=tag…#3116strailov wants to merge 3 commits into
strailov wants to merge 3 commits into
Conversation
…1) failing on EclipseLink/MySQL Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
avgustinmm
requested changes
Jun 4, 2026
| update.where(update.getRoot().get(AbstractJpaBaseEntity_.ID).in(chunk)); | ||
| entityManager.createQuery(update).executeUpdate(); | ||
| } | ||
| offset += CHUNK_SIZE; |
Contributor
There was a problem hiding this comment.
is there granted db will return as much as possible up to CHUNK_SIZE? or db could decide to return less (as for instance InputStream with buffer works?) - maybe not
so better increment with the chunk.size() and exit if empty, not when != CHUNK_SIZE
Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
avgustinmm
reviewed
Jun 5, 2026
| // BUG Reported: https://github.com/eclipse-ee4j/eclipselink/issues/2757 | ||
| // Hibernate: applies predicate directly to the UPDATE root — Hibernate handles | ||
| // NOT EXISTS subqueries correctly in CriteriaUpdate context. So this problem does not exist there. | ||
| if (containsNegation(rsql)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (containsNegation(rsql)) { | |
| if (Jpa.JPA_VENDOR == Jpa.JpaVendor.ECLIPSELINK && containsNegation(rsql)) { |
|
|
||
| List<Long> chunk; | ||
| int offset = 0; | ||
| final int CHUNK_SIZE = assignTargetGroupChunkSize; |
Contributor
There was a problem hiding this comment.
CHUNK_SIZE -> chunkSize, and it's not actually needed - you could use assignTargetGroupChunkSize directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…1) failing on EclipseLink/MySQL