fix(harmonia): the document items table shows the display columns, not every editable column - #6525
Merged
Merged
Conversation
…t every editable column The read-only items table on all three document surfaces (application, my, partner) iterated editColumns - the full add/edit-dialog metadata - so a relation marked major:false (hidden from tables by contract) still rendered as a table column. The table now shows the display-column set (which honors major:false), carried with the full edit metadata so lookup labels, dates and number patterns keep rendering; the dialog keeps editColumns, so a hidden Depends-On trigger (pick a Product -> name/price/UoM/tax fill in) stays editable. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The document page's read-only items table (application shell, My shell, Partner shell) renders
editColumns- the full metadata meant for the add/edit dialog. A relation the model hides from tables (major: false, honored by the display-column list) therefore still appears as a table column: a line-item's Product picker, UoM and tax-rate selectors all render as columns although the Name/quantity/derived-amount columns are the document's actual reading surface.Fix
The table iterates a filtered set: the display columns (which honor
major: false) carried with their full edit metadata, so lookup labels, date and number formatting keep working. The dialog keepseditColumns- a hidden Depends-On trigger (pick a Product → name/price/UoM/tax fill in) must stay editable there. Same change on all three shells; colspans follow.Verified live: a regenerated invoice document renders the reduced table (name/quantity/price/discount/vat-rate/net/vat/total) while the line dialog still offers Product/UoM/TaxRate.
🤖 Generated with Claude Code