fix(i18n): custom per-record action buttons localize — translation keys + catalog labels (#6523) - #6524
Merged
Merged
Conversation
…rry translation keys, labels land in the catalog (#6521) On a localized generated app the per-record action buttons stayed English: the transition buttons (Void), the create-from buttons (Save as Template, Record Reminder) and the built-in Duplicate, plus the chat/upload strings. Two gaps: the catalog template missed nine defaults.* keys the views reference (T() fell back silently and downstream language catalogs never saw them), and the generated transition/generates descriptors emitted only a raw label although the renderer already supports T(action.translation.key, label). The nine keys are added to the catalog template. The descriptors now carry translation: {key: "<project>:<model>-model.actions.<name>"}; EdmIntentGenerator puts a customActionLabels map on the .model root (label derivation shared with the descriptors via IntentNaming.customActionLabel - authored label: else humanized name), and the template engine's model translate action folds it into the generated en catalog's actions section. IntentEngineIT locks both halves: the generate-action descriptor carries the model-catalog key and the en catalog carries the actions section (green locally); engine-intent 300/300 unit tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
delchev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6523.
On a Bulgarian-localized app the per-record action buttons stayed English — transitions (Void), create-from actions (Save as Template, Record Reminder), the built-in Duplicate, and a set of chat/upload strings. Two independent gaps, both fixed:
defaults.*keys the views reference were missing from the generated catalog template (duplicate,send,status,system,internal,internalNote,writeMessage,upload,uploading) —T()silently fell back to English and downstream language catalogs never saw the keys. Added with the views' exact default texts.T(action.translation.key, action.label); the descriptors now emittranslation: { key: "<project>:<model>-model.actions.<name>" }.EdmIntentGeneratorputs acustomActionLabelsmap on the.modelroot — one label derivation shared with the descriptors (IntentNaming.customActionLabel: authoredlabel:, else the humanized name) so the catalog entry always matches the button's fallback — and the template engine's model translate action folds it into the generated en catalog'sactionssection, where downstream language tooling picks it up like any other label.Tests:
IntentEngineITlocks both halves on the generates fixture — the descriptor carries the model-catalog key, and the generatedi18n/en-US/<model>.jsoncontains theactionssection (targeted IT green locally). engine-intent 300/300 unit tests.The BPM task form's own labels (Approve, field labels) are a separate untranslated surface — filed as #6522.
Template/generator-only — reaches deployed apps on regeneration (+ downstream bg catalogs on their next sync).
🤖 Generated with Claude Code