fix(harmonia): composition-parent FK never renders as a detail-form input (#6513) - #6514
Merged
Conversation
…rm input (#6513) A detail's create/edit form (a company's bank-account dialog) still offered the parent as an editable dropdown. The parent is never the user's choice there: the master's panel presets the FK via the create query param and an edit round-trips it - exactly like every other master-detail surface, which already hides the master FK (items dialog, detail tables). Offering it invited re-parenting by accident and was redundant inside the dialog. The generated form view now excludes relationshipType=COMPOSITION properties from the editable grid; the value stays in the form model (preset on create, loaded on edit) like the other hidden system fields. IntentEngineIT locks it: the generated detail form renders no parent input while the detail's own fields stay editable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6513.
The generated detail create/edit form (e.g. a company's bank-account dialog, #6509) still rendered the composition-parent FK ("Company") as an editable dropdown. The parent is never the user's choice on a detail form — the master's panel presets it via the create query param and an edit round-trips the stored value — and every other master-detail surface already hides the master FK (the document items dialog and the detail tables exclude it by construction).
One-line template fix: the editable grid in
manage/form-view.html.templateskips properties withrelationshipType="COMPOSITION", alongside the existing exclusions (PK, read-only/system, DOCUMENT_STATUS, audit). The value stays in the form model — preset on create, loaded on edit — so binding and validation are unchanged; only the input is gone. A dropdown options fetch for it no longer matters visually and is left untouched (harmless).IntentEngineITlocks the emission: the generatedOrderItem-form.htmlcontains nof_Ordercontrol whilef_Quantitystill renders.Template-only — reaches deployed apps on the next regeneration.
🤖 Generated with Claude Code