Skip to content

fix(harmonia): printed PDF blob URL outlives its tab; popup-blocked prints download instead (#6511) #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delchev merged 1 commit into from
Aug 4, 2026
Merged

fix(harmonia): printed PDF blob URL outlives its tab; popup-blocked prints download instead (#6511) #6512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...e/template-application-ui-harmonia-java/ui/perspective/document/document-page.js.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,21 @@ document.addEventListener('alpine:init', () => {
}
const blob = await response.blob();
const url = URL.createObjectURL(blob);
window.open(url, '_blank');
setTimeout(() => URL.revokeObjectURL(url), 60000);
// The object URL must outlive the tab that renders it: a timed revoke kills the PDF
// viewer's reload/print the moment it fires (observed live - the blob tab worked once,
// then "the file was removed"). The URL is released when THIS page unloads, which is the
// blob's natural owner lifetime; a print-sized PDF held until then costs nothing.
const opened = window.open(url, '_blank');
if (!opened) {
// Popup blocked - the open runs after async work, outside the click's gesture stack.
// Fall back to a download, which the browser always allows.
const link = document.createElement('a');
link.href = url;
link.download = '${name}-' + this.id + '.pdf';
document.body.appendChild(link);
link.click();
link.remove();
}
} catch (e) {
console.error('Print failed', e);
this.printError = 'Print failed';
Expand Down
17 changes: 15 additions & 2 deletions ...rigible/template-application-ui-harmonia-java/ui/perspective/manage/form-page.js.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,21 @@ document.addEventListener('alpine:init', () => {
}
const blob = await response.blob();
const url = URL.createObjectURL(blob);
window.open(url, '_blank');
setTimeout(() => URL.revokeObjectURL(url), 60000);
// The object URL must outlive the tab that renders it: a timed revoke kills the PDF
// viewer's reload/print the moment it fires (observed live - the blob tab worked once,
// then "the file was removed"). The URL is released when THIS page unloads, which is the
// blob's natural owner lifetime; a print-sized PDF held until then costs nothing.
const opened = window.open(url, '_blank');
if (!opened) {
// Popup blocked - the open runs after async work, outside the click's gesture stack.
// Fall back to a download, which the browser always allows.
const link = document.createElement('a');
link.href = url;
link.download = '${name}-' + this.id + '.pdf';
document.body.appendChild(link);
link.click();
link.remove();
}
} catch (e) {
console.error('Print failed', e);
this.printError = 'Print failed';
Expand Down
Loading