fix(numbering): per-row save in settings; base row of a partitioned series offers no counter (#6499) - #6500
Merged
Merged
Conversation
…partitioned series offers no counter (#6499) Two live-observed defects on the Document Numbering settings page. The single Save/Reload pair below the whole series list was off-screen with a real application's dozens of series - users edited Next, saw no way to save, and left. Save now sits ON each row, enabled only when that row's edits differ from what was loaded; only what changed is written (the endpoint's writes are change-tracked, so an unchanged next never rewinds the live counter), and saving one row refreshes only that row's baseline so other rows' in-progress edits survive. And the base ("") row of a PARTITIONED series is only the shape template new partitions inherit at birth - allocation always draws from a partition row - yet the page offered its Next for editing, which looked like seeding the next document number and did nothing. The series view now carries a `partitioned` flag; the base row of a partitioned series renders no Next input (shape stays editable) plus one line of copy explaining where counters live. NumberingSdkIT gains the settings-surface case: a partition row's Next edit round-trips and IS what the next issued number renders, while a base-row Next edit does not affect partition allocations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6499.
What
saveNumberingRow), enabled only when the row differs from its loaded baseline; only the changed halves are written (shape viaPUT /shape, counter viaPUT- the endpoint's writes were already change-tracked so an unchanged Next never rewinds a live counter). Saving one row updates only that row's baseline, so in-progress edits on other rows survive; a transient "Saved" confirmation appears on the row. Reload moved to the top of the list.DocumentNumberEndpoint.SeriesViewgains apartitionedflag (true once any partition row of the series exists); the base row of a partitioned series renders no Next input and no "Next number" preview - its shape stays editable - plus one line of copy: "Counters live on the per-partition rows below; a new partition appears on its first use, inheriting this shape." (en + bg catalog entries added.)Test
NumberingSdkIT.theSettingsSurfaceSeedsPartitionCountersAndTheBaseRowIsOnlyTheShapeTemplate(green locally): materializes a partition, asserts thepartitionedflag on both rows overGET /services/core/numbering, edits the BASE row's Next (must not affect partition allocations), edits the PARTITION row's Next to 42 and asserts the round-trip and that the next allocated document renders exactlyT-0042- the outermost observable layer of the seeding contract.🤖 Generated with Claude Code