[codex] simplify Blade codebase by 30% - #38
Conversation
生产端零调用,仅被单测引用;combineAbortSignals 已覆盖同类场景。 一并移除对应的单测用例。
Task 与 Team 工具原本以 8 个位置参数(Task)和散开的 options 字段(Team) 重复传递同一组委派依赖,getBuiltinTools 还需逐字段转发。引入声明式的 SubagentDelegationDeps 容器统一承载 registry、资源快照与偏好选择器, 以命名依赖注入替代样板透传,并清理由此产生的死 import。 - createTaskTool 改为接收容器,函数体通过解构保持不变 - TeamToolOptions 继承容器,去掉重复且误名的 subagentRegistry 字段 - getBuiltinTools 单次构建容器并复用,公共 opts 签名不变
|
Important Review skippedToo many files! This PR contains 798 files, which is 698 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (798)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Final validation for
|
1. 修复 Skill 工具限制释放逻辑,在逻辑回合完成/失败/取消/关闭时释放限制,保留同回合 Plan 批准的限制,并发请求拒绝不改变活动回合状态 2. 添加、完善多项单元与集成测试,覆盖 Agent 技能生命周期、ACP 会话、无头模式、运行时状态等场景 3. 删除冗余的 MCP 客户端、插件安装器 Git 传输、UI 工具格式化相关测试文件 4. 更新中英文文档与变更日志,补充技能限制相关说明
Summary
8bcd2696Impact
The branch removes broad duplication while retaining supported behavior across CLI, TUI, Web, ACP, tools, sessions, providers, plugins, hooks, and subagents.
Large regression matrices were replaced by focused boundary suites and shared fixtures. The default suite remains deterministic, while paid real-API qualification continues to cover production paths that cannot be established locally.
See
docs/design/codebase-simplification.mdfor the architecture and ownership map.Validation
bun run --filter blade-code qualify:local: 14/14 checks passedbun run --filter blade-code test:coveragethe subsequent commit only finalizes the documented metrics
Paid real-API calls were not executed. Release-matrix selection, production trajectory wiring, and credential isolation were verified deterministically.
Notes
The working tree contains unrelated local changes that are intentionally not part of this PR.