Local icon loading is now async and reduces disk reads for performance#2196
Open
ebkr wants to merge 2 commits into
Open
Local icon loading is now async and reduces disk reads for performance#2196ebkr wants to merge 2 commits into
ebkr wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance improvement for local icons
Converts loading to async, and happens for each mod exactly once per profile
Why?
Previously every time someone would access their installed mod list, every single icon would be read from disk.
This is unnecessary as they don't change. If a mod itself has changes then the comparison key will differ and they'll be re-looked up.