Group installed games on game select screen

[patttterson]

Warning

not tested on windows. please help me out :3

This PR follows from #2132 and uses the game grouping system from #2135

Preview

 

[patttterson]

i couldn't resist, lmk if you want it removed LOL

[patttterson]

@ebkr i have remade it 🙏

[TB516]

Making it so favoriting a game removes it from the installed list might be nice, so there aren't duplicates.

[patttterson]

Making it so favoriting a game removes it from the installed list might be nice, so there aren't duplicates.

ahh, i added that intentionally LOL
im fine with either, will see what they think ig

[ebkr]

I think that the duplicates are fine. The problem is more just that favourites appear first so it looks odd.

I really like the idea of this, and we've been having some internal discussions but there are some concerns. Not about the implementation but more about the UX, but bear with me because they somewhat lead into each other:

---

"Installed games" is misleading if we only support one store. People will think that another game that they may have installed isn't support solely because it doesn't appear in that list. There are other issues with multiple installs and stuff which is a smaller concern, but still a concern.

Anyway, if we rename this to "Installed Steam games", great. But not quite.
If you click "Select game" when in the "Installed Steam games" section, would you expect it to default to that platform?

• On one hand, yes. I've selected a game I have installed on Steam, therefore I clearly want to load that Steam game
• On the other hand, no. That's the first listing for that game that I've seen and it's readily available, therefore I'll just click that and select my platform.

---

It's a bit of a double-edged sword and I think we need to have an internal discussion regarding the best way to approach this before I get back to you on it.

Again, I do like the idea of showing installed games, it's just a little nuanced.

[patttterson]

Ahhh, it didn't even occur to me that r2modman supports other platforms LMAO

Maybe a secondary menu for selecting steam games? Like you can pick whether to use a steam install or.... whatever the other options are

The problem is more just that favourites appear first so it looks odd.

I'll update this though

[ebkr]

To clarify regarding the favourites appearing first, I don't mean the section.

The section should probably stay where it is, it's more that the installed games section probably shouldn't order the favourites

[patttterson]

oh lmao

[patttterson]

YAOOOOOO MY BAD I CANT USE GIT

anyway preview :3 (works on macos thou! check that out)

[patttterson]

the game list sorting here is redundant, as filtering to favorites (or only non-favorites) makes it alphabetical anyways

[patttterson]

check that though i coded this in the backseat on a spotty connection at 11 pm