internal/fakecgo: compilation error for old Go - #487
Closed
hajimehoshi wants to merge 1 commit into
Closed
Conversation
PureGo 0.10 needs to support Go 1.18 where range over integers is not available. This change fixes this. Updates ebitengine#485
Member
Author
|
The target is 0.10 branch, not main. PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation error on older Go toolchains by removing the newer “range over integer” loop form from internal/fakecgo’s threadentry regression test, keeping the test runnable across supported Go versions.
Changes:
- Replace
for range rounds {}with a classic indexedfor i := 0; i < rounds; i++ {}loop. - Replace
for range workers {}with a classic indexedfor j := 0; j < workers; j++ {}loop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Hmm, this might be related to changes in main that are not in 0.10. That's unfortunate, but I'll revert the cherry-picking the fix for #485. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Updates #485
What type of issue is this addressing?
bug
What this PR does | solves
Fixes a compilation error for old Go where range over integers is not available.