Rework diffusion models#191
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
- Coverage 98.42% 98.13% -0.29%
===========================================
Files 50 51 +1
Lines 3175 3542 +367
Branches 576 652 +76
===========================================
+ Hits 3125 3476 +351
- Misses 26 36 +10
- Partials 24 30 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thread 1 — Double-counting Good catch, and well fixed. Thread 2 — Aggressive reset on Q change in I think your reasoning sounds good for now. The key points:
My suggestion would be to leave the current behaviour as-is for this PR (since it's documented that Q changes are destructive), but perhaps add a note in the docstring of
|
The changes are described here: #190
I'm missing some tests, but the code is more or less how I want it to be, so a review would be nice