Repository navigation
fix(plugin): encode plugin requests deterministically - #244
Merged
Yakwilik merged 1 commit intoOct 26, 2026
Merged
Conversation
- custom options are dynamic messages; plain proto.Marshal orders their fields randomly, so plugins that embed descriptors (es) produced different output on every run - route command, local and builtin executors through marshalRequest Fixes easyp-tech#243
Yakwilik
self-requested a review
October 22, 2026 15:11
Yakwilik
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243.
The command, local and builtin executors now encode
CodeGeneratorRequestthrough one helper that setsDeterministic: true, which is what descriptor set output already does.Checked two ways.
TestMarshalRequestIsDeterministiccompiles a file with message-typed custom options and encodes the request 100 times; it fails on plainproto.Marshal. Then I raneasyp generate20 times against a local plugin that dumps its stdin: current main produced 5 distinct requests, this branch produced 1.The remote executor goes through gRPC's codec and isn't changed here.