R: Catch json parse errors - #55
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
===========================================
+ Coverage 49.80% 96.68% +46.87%
===========================================
Files 9 2 -7
Lines 520 392 -128
Branches 27 0 -27
===========================================
+ Hits 259 379 +120
+ Misses 258 13 -245
+ Partials 3 0 -3
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the R route layer so endpoints that parse JSON request bodies return a structured 400 response when the body is invalid JSON, and adds route tests for malformed JSON inputs.
Changes:
- Added a shared JSON parsing helper that converts parse failures into JSON error responses.
- Applied the helper to POST handlers that parse request bodies.
- Added tests for malformed JSON and JSON-string request bodies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
R/R/route.R |
Adds shared JSON parse error handling and applies it to relevant route handlers. |
R/tests/testthat/test-route.R |
Adds regression tests for malformed JSON request bodies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON parser in reqres is more picky causing
This PR catches the json parse error and returns them.