Add 'ERA5-Land' dataset to predefined datasets - #499
Open
MarkMelotto wants to merge 13 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 79.17% 80.74% +1.57%
==========================================
Files 28 29 +1
Lines 1882 2010 +128
Branches 168 195 +27
==========================================
+ Hits 1490 1623 +133
+ Misses 330 327 -3
+ Partials 62 60 -2
🚀 New features to boost your workflow:
|
Contributor
Author
|
@BSchilperoort I dont see why this should not be fine |
* add support for monthly GRDC station .txt file and 1 test * placeholder docstring * minor formatting * docstring * updated docstring with data description for original/calculated/flag
…493) * split hydrograph from __init__.py * add helper _to_pandas * update error message * update logic and error messages * update hydrograph * gitignore * update init * update test * tests * changed graph * added some TODO notes * fixed typo * some more changes, distinction one ore more * small fixes * update title and docstring * table column names from hydrostats * initial discharge_statistics * init py * init.py * completely revamped hydrograph to reduce complexity * gitignore * updated tests * gitignore * figures * prepare for PR * remove empty lines * changed docstring discharge * test metrics_list * test for y_sim shape = 1 * update test for single comparison * remove unused data from tests * lint whitespace * ruff update * update ruff * more ruff format * remove old test
Contributor
Author
|
added the work of @andrevdv to this PR so that it is the latest version of eWaterCycle |
BSchilperoort
requested changes
Aug 31, 2026
| """ewatercycle analysis module.""" | ||
|
|
||
| import os | ||
| from . import hydrograph |
Member
There was a problem hiding this comment.
Suggested change
| from . import hydrograph | |
| from ewatercycle.analysis import hydrograph |
| import numpy as np | ||
| import pandas as pd | ||
| import xarray as xr | ||
| from HydroErr.HydroErr import function_list |
Member
There was a problem hiding this comment.
This package isn't in the pyproject.toml. I guess it is installed via a different dependency. Should be added to direct dependencies though, as it's use directly here.
| return default | ||
|
|
||
|
|
||
| ##------- Monthly GRDC data ---------- |
Member
There was a problem hiding this comment.
Suggested change
| ##------- Monthly GRDC data ---------- |
| ## - GRDC Monthly tests | ||
|
|
||
|
|
||
| def sample_grdc_monthly_file(tmp_path): |
| return fn | ||
|
|
||
|
|
||
| def expected_results_monthly(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started as a 'adding ERA5-Land' now has become the start of eWaterCycle 2.5 PR