Repository navigation
Simplify vote log freshness tests - #672
Merged
Merged
Conversation
* Replace the four vote log freshness tests with a single test. * Only the fully compacted case reproduces the bug fixed in eBay#668; the other three pass with or without the fix. * Drop unused setup: extra log appends, the stale follower log, and unrelated raft params. * Keep three vote checks: reject a shorter log, reject a lower term, and grant an equally up-to-date log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the four vote log freshness tests with a single test.
Only the fully compacted case reproduces the bug fixed in Fix RequestVote freshness after full log compaction #668; the other three pass with or without the fix.
Drop unused setup: extra log appends, the stale follower log, and unrelated raft params.
Keep three vote checks: reject a shorter log, reject a lower term, and grant an equally up-to-date log.