Repository navigation
Fix configuration without Asio headers when DISABLE_ASIO is enabled - #669
Merged
greensky00 merged 1 commit intoOct 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-DDISABLE_ASIO=ON, CMake skips finding Asio but still unconditionally fails whenASIO_INCLUDE_DIRis absent. A clean checkout therefore cannot build without Asio installed.Guard the header check and include-directory setup with the same option. Add a separate CI job that configures, builds, and tests without running
prepare.shor installing Asio. The Asio-enabled configuration keeps its existing required-header check.Validation: reproduced the configuration failure on the base revision; the fixed configuration builds successfully and all 10 available CTest tests pass.
Prepared with Codex assistance.