Repository navigation
feat(web): disable upstream GitHub star prompt on fork - #36
Conversation
 [Low impact] The changes stay within the fork's web prompt and upstream-edit check. Add the missing footprint budget entries before merging; the default-off test also needs a small improvement. Findings
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "apps/mobile/src/features/threads/ThreadComposer.tsx": 11, | ||
| "apps/mobile/src/features/threads/ThreadDetailScreen.tsx": 30, | ||
| "apps/mobile/src/features/threads/ThreadFeed.tsx": 244, | ||
| "apps/mobile/src/features/threads/ThreadFeed.tsx": 243, |
There was a problem hiding this comment.
The budget omits both changed GitHubStarPrompt files. Against the upstream commit merged into the PR base, GitHubStarPrompt.tsx has 11 changed lines and GitHubStarPrompt.test.ts has 12. The checker gives missing entries a limit of zero and exits with an error.
Changing this budget file triggers the Fork machine groups workflow, so its footprint check fails. Add reviewed entries for both files.
| it("never asks when disabled on the fork by default", async () => { | ||
| setup({ sent: 5, enabled: false }); | ||
| await (await startSession()).send(); |
There was a problem hiding this comment.
The new “disabled on the fork by default” test explicitly sets enabled: false, and startSession() writes that value before calling recordPromptSent(). It therefore passes even if the production default changes back to true.
Leave the setter unused in this case so the test protects the fork's actual default. Keep the override for the existing enabled-path tests.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Disables the upstream GitHub star prompt (pingdotgg#29922, pingdotgg#29987) on the EK fork while preserving test coverage.