fix: set PRAGMA busy_timeout before schema init - #8
Closed
sara-lolatte wants to merge 2 commits into
Closed
sara-lolatte wants to merge 2 commits into
sara-lolatte wants to merge 2 commits into
Conversation
- scripts/risk-gate.ts classifies PRs low/medium/high by protected paths, size, deleted tests and secret patterns; unit-tested in test/risk-gate.test.ts - risk-gate.yml labels the PR, posts a sticky verdict, enables auto-merge for low (and medium with ai-review:pass), and fails the check for high until a human approves - claude-review.yml runs claude-code-action against .github/review/RUBRIC.md and docs/agent-learnings.md; posts a visible skip notice when no API key - CODEOWNERS mirrors the protected paths as a GitHub-native backstop Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
CREATE TABLE IF NOT EXISTS is a write; on a fresh DB, parallel first-run CLI invocations raced it before the busy timeout was applied, producing SQLITE_BUSY (1-4 of 40 runs locally). Reproduced via test/db-busy-timeout.test.ts, which now passes consistently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Apologies — opened against upstream by mistake from a fork used for an exercise. Closing; not intended for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bug fix found while baselining the fork:
test/db-busy-timeout.test.tsfailed 1-4/40 on macOS because the busy timeout was set after theCREATE TABLE IF NOT EXISTSwrites.Expected path:
src/db.tsis a protected path →risk:high→ Risk Gate fails until a human with write access approves. Left open deliberately as the live demonstration of the blocked route.