Repository navigation
Add parameter types to test methods - #76
Merged
Merged
Conversation
Types as supplied by the data providers; mixed where tests deliberately pass arbitrary or invalid input (constructor arguments, locale of FormatterFactory::getFormatter()). Completes #58 (short array syntax, parameter and return types in tests). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweichert
added a commit
that referenced
this pull request
Oct 25, 2026
- Ticked off: release plan and SECURITY.md on main, modernisation (#71, #76), output identical to v1.1.6, README for 2.0, private vulnerability reporting enabled. - Release day: merge main into this branch and re-run the tests and the comparison with 1.1 before merging. - #58 is closed by #76. - Release plan: remove the resolved open points (README support table, private vulnerability reporting). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter types on all parameterised test methods, as supplied by the data providers (checked by reflection over all providers);
mixedwhere tests deliberately pass arbitrary or invalid input (constructor arguments, locale ofFormatterFactory::getFormatter()).Together with #71 (short array syntax, return types, PHPUnit 13 attributes) this completes the test refactoring.
Closes #58
Tests only, no library change: 192 tests green on PHP 8.6.
🤖 Generated with Claude Code