Bring docs up to date for 0.3.0 - #12
Merged
Merged
Conversation
- README: document products.get_cards / get_week_sales and delivery.get_addresses / get_active_address_id (added in 0.2.0 but never documented); complete the error contract (batch operations, login's RohlikAPIError, get_shopping_list's ValueError); mention the other Rohlík Group shops in the intro and credentials section; link the "Other shops" section from Features. - PUBLISHING.md: describe the actual release flow (publish a GitHub Release -> trusted-publishing workflow) instead of asking to create a workflow that already exists. - example.py: its docstring claimed the network calls were commented out; it now says what runs, and shows shop selection via SITES plus the newer methods and cart fields. - pyproject: PyPI description and keywords cover the other shops. - Package and client docstrings no longer say Rohlik.cz only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0135WLPbnfESWnAJmw4P8uRH
Owner
Author
|
@claude review this PR. It is docs-only: check that every README, PUBLISHING.md, example.py and docstring claim matches the actual code and the publish workflow (method names, signatures, return types, error behavior). Generated by Claude Code |
|
Claude finished @dvejsada's task in 1m 20s —— View job Review of PR #12 — docs update for 0.3.0
I checked every documentation claim in this PR against the actual implementation. Everything I verified matches the code exactly — no discrepancies found. What I verifiedREADME.md
PUBLISHING.md
example.py
pyproject.toml / docstrings
Minor observations (not blocking, purely optional)
No code changes needed. This PR is ready to merge as-is from a documentation-accuracy standpoint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a docs-only update ahead of the v0.3.0 release. The README becomes the PyPI project page, so it should be accurate before the release is published. There are no code changes beyond docstrings.
What was out of date
products.get_cards,products.get_week_sales,delivery.get_addressesanddelivery.get_active_address_idwere added in 0.2.0 but never documented. They are now listed, together with howget_next_slotsresolves an address when login doesn't return one.cart.add_itemsreturns only the IDs it added, andorders.get_all_deliveredreturns the orders gathered so far if a page fails;RohlikAPIErrorfor any unexpected status;get_shopping_listraisingValueErrorwhen called without an ID.is_logged_in,user_idandaddress_idproperties.PUBLISHING.md: it asked you to createpublish.yml, which already exists, and described a tag-push flow. It now describes the real flow:__version__,v<version>,example.py: its docstring claimed the network calls were commented out, but it logs in and makes three calls. The docstring now says what runs. The example also picks the shop viaSITESand shows the new methods and cart fields.pyproject.toml: the PyPI description and keywords now cover Knuspr.de, Gurkerl.at, Kifli.hu and Sezamo.ro.login/logout/get_datadocstrings no longer say Rohlik.cz only.loginnow documents that it can raiseRohlikAPIError.Testing
ruff check .,black --check .andmypy rohlik_apipass.pytest: 152 passed.python -m buildproducesrohlik_api-0.3.0(wheel and sdist), andtwine checkpasses on both.🤖 Generated with Claude Code
https://claude.ai/code/session_0135WLPbnfESWnAJmw4P8uRH
Generated by Claude Code