Repository navigation
Conversation
The driver's adminPrefix option is gone: core no longer assumes /admin, so an admin must provide the admin.prefix capability, and the suite reads the prefix from it. adminPrefix?: string becomes hostsContributions?: boolean (it only enables the admin.pages / admin.routes checks). New checks: the admin provides admin.prefix, core reserves it against plugin routes, and with no admin /admin is an ordinary path. The stub admin provides admin.prefix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Core no longer loads an admin by itself, so there is nothing to disable; a test that wants an admin lists it in plugins. Part of 2.0.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Follows @dune/core's rename of the permission resource (duneorg/dune#130). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…une#125) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
marked this pull request as ready for review
November 10, 2026 16:34
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3 (base
feat/stub-admin); part of duneorg/dune#123, step 2.What
Core no longer assumes the admin lives at
/admin; an admin provides theadmin.prefixcapability slot. The conformance suite follows:AdminConformanceDriver.adminPrefix?: stringis removed. The suite reads the prefix from the slot.hostsContributions?: booleanreplaces it and only switches on theadmin.pages/admin.routeschecks.admin.prefix(exactly one provider; starts with/, no trailing slash); core reserves that prefix against plugin routes; with no admin,/adminis an ordinary path for plugins.admin.prefix(/stub-adminby default).admin.prefix, and ones with unusable prefixes (/stub-admin/,stub-admin,/), are rejected.Breaking
Version 2.0.0: a driver that set
adminPrefixmust sethostsContributions: trueinstead, and its admin must provideadmin.prefix.Tests
deno task checkclean; 44 tests pass against core's step 2 branch (duneorg/dune#126). Needs@dune/core0.36.🤖 Generated with Claude Code