Repository navigation
Conversation
…eorg/dune#97) setup() declares the inline-edit slot with api.capabilities.provide instead of adminServices(); transformResponse collects the admin bar's buttons from ResponseTransformContext.barActions instead of ctx.plugins[].adminBarActions. Needs @dune/core 0.36; major version bump (3.0.0) at release. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…eorg/dune#122) Core 0.36 names the slot editor.inline, matching auth.session and editor.content. No alias: a core without the rename will not find the manager. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t needs no admin.enabled override Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Landed in 3.0.0 as part of #9 (one squash of the whole stack). Verified against the published @dune/core 0.36.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of duneorg/dune#97 (step 4) and #64. Draft until
@dune/core0.36 is published; it also needs the core capability PRs (duneorg/dune#109, #110, #111).Core 0.36 replaces
DunePlugin.adminServices,adminBarActionsandResponseTransformContext.pluginswith a typed capability registry. This moves the plugin over:inline-editcapability insetup()(api.capabilities.provide("inline-edit", ...)), built from the capability context (storage, history, data dir, content dir, hooks). Core's/api/inline-edit/wsupgrades through it and the admin's content endpoints use it for commits and presence.bar.actions:transformResponsereadsResponseTransformContext.barActions, which carries what other plugins contributed withcapabilities.contribute("bar.actions", fn). The bar still doesn't know what the buttons do.AdminServicesContextare reworded.Not in this PR (release work): the version bump to 3.0.0 and the
@dune/corepin to^0.36.0. The pin cannot resolve until 0.36 is on JSR.Tests.
deno task checkanddeno task testpass (48, against the local capability-stack core). New: the slot is provided and its factory builds a working manager;transformResponserenders deliveredbarActions; visitors without edit rights get the response untouched; andtests/core_integration_test.tsruns against real core: without the plugin/api/inline-edit/wsanswers 501, with it core resolves the slot (active, providerinline-edit) and the route proceeds to the WebSocket checks (426).deno.dev.jsongains two local core mappings (bootstrap,fresh-app) for that test.🤖 Generated with Claude Code