Repository navigation
fix: log failed saves and dropped frames; plugin.version matches deno.json - #4
Merged
Merged
Conversation
….json Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
What
Failures in the collaborative editing path were swallowed by empty
catches: a failed save of the Y.js document, a failed flush, a throwingonPageUpdatehook, and any error while handling a websocket frame. A user could lose edits with nothing in the log.plugin.versionalso reported2.1.4against2.2.3indeno.json.Change
src/log.ts:warnThrottled(key, message, err)logs at most one line per key per minute, so a misbehaving client cannot flood the log.ws-server.ts,manager.ts,commit.ts: the swallowing sites now call it (persist,flush,hook,frame). Behaviour is otherwise unchanged; none of these failures break the session.src/mod.ts:versionset to2.2.3.Testing
tests/log_test.ts: throttling per key and over time, andplugin.versionequalsdeno.json's version.deno task testpasses (43) anddeno task checkpasses.Not changed: the intentional
catchfor a new or missing content file inmanager.ts.🤖 Generated with Claude Code