Repository navigation
feat: mirror the split contract (plugins own their extension points) - #2
Merged
Merged
Conversation
…nd form contracts First slice of the plugin contract. Copied from @dune/core where the shape is already the public one, narrowed where core's is wider than a plugin needs (SearchEngineCreateContext). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… (slice 2a) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ions (slice 2b) DunePlugin, PluginApi, MountApi, HookRegistry, HookContext and the hook events; the capability slot and contribution types; a narrow DuneConfig and PluginAuthz; PluginRuntime with narrow structural interfaces for the engine, router, theme loader, search, flex, submissions, sections, metrics and jobs. Handlers and plugin callbacks are bivariant so core's wider contexts are accepted. Also drops two unused imports left by slice 2a. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
User loses avatarUrl, providerId, linkedProviders, lastSeenAt and stripeCustomerId; UserStore loses getByProvider, linkProvider and unlinkProvider. PageIndex loses gated, roles, publishAt, unpublishAt, fileUrl, termPageFor and coverImage. Nothing in the first-party plugins or the testing harness reads them; adding a field later is additive, removing one is not. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
providerId, linkedProviders, getByProvider, linkProvider and unlinkProvider are what a third-party OAuth login provider is built from. No first-party plugin uses them yet; they stay so one can be written against the 1.0 contract. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Where the admin is mounted. Core reads it instead of assuming /admin; with no provider there is no admin. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…une#125) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…wn extension points (#127) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
marked this pull request as ready for review
November 10, 2026 12:53
# Conflicts: # CHANGELOG.md # src/capabilities.ts # src/hooks.ts # src/mod.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of duneorg/dune#127. Stacked on #1; mirrors the core contract-split PR (duneorg/dune#133).
Extension points belong to the plugin that reads them:
AdminPageRegistration,AdminRouteRegistration,ContentEditorPluginand the bar-action types leave this contract (core never read them).ResponseTransformContextcarriescapabilitiesinstead ofadminPrefixandbarActions.(The first version of this PR used module augmentation, which JSR rejects in a published package; #3 replaces it with typed keys.)
🤖 Generated with Claude Code