Repository navigation
Conversation
Inline edits and other writers fire the page event with the person as actor; the admin now logs page.create/update/delete for them. Events its own routes announce are marked and skipped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
marked this pull request as ready for review
November 10, 2026 16:33
zumbrunn
added a commit
that referenced
this pull request
Nov 10, 2026
Member
Author
|
Landed in 4.0.0 as part of #26 (one squash of the whole stack: its intermediate commits only type-check against the final contract). Verified against the published @dune/core 0.36.0 and @dune/testing 2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of duneorg/dune#127. Stacked on #24.
The inline-edit bar, a plugin or any other writer fires the page event with the person's name as
actor. The admin now writes apage.create/page.update/page.deleteaudit entry for it (no IP or user agent: the event does not carry them; a write with no actor is logged as the system). Events the admin's own routes announce keep writing their own entry with IP and user agent;announcePageEventmarks the payload with a non-enumerable symbol so the listener skips it, and the mark never reaches a webhook body.Not covered:
onPageMove(there is nopage.moveaudit type, and the admin's routes do not log moves either).Tests: the listener (updates, create/delete, no-actor, no double entry, no audit trail), the full suite passes.
🤖 Generated with Claude Code