Repository navigation
Conversation
…ublishes 'export default function adminPluginFactory' next to 'adminPluginFactory.pluginName = ...' is a merged declaration; JSR's type output rejects it (TS2652), so 'deno publish' failed. Same runtime shape: a function with a pluginName property. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
marked this pull request as ready for review
November 10, 2026 16:33
zumbrunn
added a commit
that referenced
this pull request
Nov 10, 2026
Member
Author
|
Landed in 4.0.0 as part of #26 (one squash of the whole stack: its intermediate commits only type-check against the final contract). Verified against the published @dune/core 0.36.0 and @dune/testing 2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22. Stacked on #17.
Declares
adminPluginFactory, assignspluginName, thenexport default adminPluginFactoryseparately. Same runtime shape.deno publish --dry-runpasses with it (checked in the full stack, 293 tests pass).Not verified on this branch's own workspace: it resolves an older core and fails type-checking for unrelated reasons.
🤖 Generated with Claude Code