Repository navigation
Conversation
Restore, staging publish, translate x2, dev apply, reorder (new onPageMove) and collab auto-save wrote pages and fired nothing. They now share announcePageEvent(), which fires the hook and the content webhooks. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The manifest generator put /api/staging/:path* ahead of /api/staging/:path*/publish, so publish was unreachable (the upsert handler ran and 500ed). Same for the page comments routes. Routes with more segments after a shared wildcard now sort first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
added a commit
that referenced
this pull request
Nov 10, 2026
Member
Author
|
Landed in 4.0.0 as part of #26 (one squash of the whole stack: its intermediate commits only type-check against the final contract). Verified against the published @dune/core 0.36.0 and @dune/testing 2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
comparePatternsin the manifest generator sorted/api/staging/:path*ahead of/api/staging/:path*/publish, so the greedy wildcard won. Publishing a staged draft ran the upsert handler and 500ed./api/pages/:path*/comments,.../comments/:idand.../comments/:id/resolvehad the same problem.Staging is a live, documented feature (README, config, core staging engine), so I fixed the ordering instead of removing the route. Routes with more segments after a shared wildcard now register first; no route shapes changed.
tests/admin/staging_publish_test.ts: stages a draft and publishes it over HTTP, then checks the page file,onPageUpdateand that the draft is consumed. Fails with the original 500 on the old manifest.tests/admin/manifest_test.ts: ordering assertions for staging and comments.tests/adminsuite: 268 passed.Based on
feat/capabilities(PR #17) because publish.ts there already firesonPageUpdate; retarget to main after #17 merges.🤖 Generated with Claude Code