Repository navigation
Conversation
The admin: block, audit.log_file, content.allow_tsx_format and the LDAP/SAML provider config types follow core's snake_case rename. Requires @dune/core 0.36 (the dependency range is bumped when it is published). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
admin.data_dir is removed in core; resolve the directory with resolveDataDir(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 4, 2026
Closed
zumbrunn
marked this pull request as ready for review
November 10, 2026 16:33
zumbrunn
added a commit
that referenced
this pull request
Nov 10, 2026
Member
Author
|
Landed in 4.0.0 as part of #26 (one squash of the whole stack: its intermediate commits only type-check against the final contract). Verified against the published @dune/core 0.36.0 and @dune/testing 2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs duneorg/dune#96 (core PR duneorg/dune#98)
Draft, breaking. Waits for
@dune/core0.36 to be published.What
Core renames its camelCase config keys to snake_case (duneorg/dune#98, no aliases). This is the admin plugin's side: it reads the
admin:block and a few other renamed keys throughDuneConfig.Change
admin.session_lifetime,data_dir,runtime_dir,max_upload_mb,authz_store,audit.log_file, andcontent.allow_tsx_format(about 20 sites, including the inline fallback defaults inmod.ts).src/admin/auth/provider.ts) follow core'sAuthProviderConfig; the provider classes themselves are only doc-comment examples here, so only the types and examples change.dune migrate:config.Before it can merge
@dune/core0.36 published.deno.json@dune/corerange andCORE_RANGEinscripts/generate-core-imports.tsbumped to^0.36.0(left at^0.35.3here so the branch type-checks against the unreleased core locally).CI is red until the range points at a published core.
Testing
Type-checked and tested against core's
feat/config-snake-casebranch in a scratch workspace:deno checkclean,deno lint src/clean, 237 tests pass.🤖 Generated with Claude Code