Repository navigation
feat(admin)!: no default admin; password hashing comes from @dune/core - #11
Merged
Merged
Conversation
BREAKING: ensureDefaultAdmin() and the plaintext initial-password.txt are removed. The first admin is an explicit act: `dune users:create <email> --role admin --password-prompt`, or DUNE_ADMIN_EMAIL / DUNE_ADMIN_PASSWORD at boot (handled by @dune/core). A site with no enabled admin logs a warning saying how to create one. Sites that already have an admin are unaffected. Password hashing now comes from @dune/core/auth/passwords; the plugin's own copy is removed. hashPassword, verifyPassword and DUMMY_HASH are still re-exported from the admin entry point. The hash format is unchanged. Requires @dune/core 0.35.3 (duneorg/dune#84, #86). Refs duneorg/dune#69. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs duneorg/dune#69 (step 3 of the plan in the issue)
Core 0.35.3 (with duneorg/dune#84 and #86) is published; the range is
^0.35.3.What
ensureDefaultAdmin(),generatePassword()and the plaintextinitial-password.txtare removed. The first admin is an explicit act:dune users:create <email> --role admin --password-prompt, orDUNE_ADMIN_EMAIL+DUNE_ADMIN_PASSWORDat boot (core). A site with no enabled admin logs a warning with the exact command. Sites that already have an admin are unaffected.src/admin/auth/passwords.tsis deleted;login.tsx,local-provider.tsandusers.tsimport@dune/core/auth/passwords.hashPassword,verifyPasswordandDUMMY_HASHare still re-exported from the admin entry point. Hash format unchanged.generatePasswordbias test dropped with the function.Release notes for the release
Version: 3.3.0 (decided 2026-11-03: core loads the built-in admin through
^3.0, so a 4.x would need a second core release; first-run behaviour for new sites changes, existing sites with an admin are unaffected).dune newscaffolds and getting-started docs still need updating (step 4 in #69).Testing
237 tests pass,
deno checkclean,check:core-importsrun.deno fmt --checkalready fails repo-wide (159 files), so nothing was reformatted. The no-admin warning path was not exercised end to end.🤖 Generated with Claude Code