Repository navigation
fix(runtime): watchdog worker blob URL revoke race (#60) - #61
Merged
Merged
Conversation
Revoking the blob URL right after new Worker() could win against Deno's async module load and kill the process at boot. Keep the URL alive and degrade to 'watchdog disabled' if the worker errors. Fixes #60 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Review: the fix is right, and the bug is mine (the watchdog, #51).
Why I never saw it: my tests and live runs happened on a fast machine, where the load always finished before the revoke. Slow startup ( CI note: One thing worth watching separately: boot on flex is ~77 s and the watchdog's startup limit is 120 s. #62/#63 and plugin-pdf#6 take ~37 s off that, which is why they matter beyond speed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
new Worker()(races Deno's async module load; crashed boot on 0.35.0).errorhandler: a load/runtime failure logs and disables the watchdog instead of exiting the process.revokeObjectURL. Changelog entry added under Unreleased.Note: I couldn't reproduce the original race locally (Deno 2.9.5, with and without
--cpu-prof), so the load-failure test covers the new error path rather than the race itself.🤖 Generated with Claude Code