Repository navigation
test: the scaffold closure test ignores the contract packages - #147
Merged
Merged
Conversation
core's deno.json imports @dune/plugin-api and @dune/theme-api for the compat tests under tests/contract/ only; they are not runtime dependencies, like @std/assert, so a scaffolded site's import map does not need them. Without this the test fails as soon as either compat PR (#118, #119) adds its import. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffold's import-map closure test treats every import in core's
deno.jsonas a runtime dependency, exempting only@std/assert. #118 and #119 add@dune/theme-apiand@dune/plugin-apithere for the compat tests undertests/contract/, which are not runtime dependencies, so the test fails on both (the only red check once the packages were published). This exempts the two the same way as@std/assert.Once this is on
main, #118 and #119 needmainmerged in and should go green.🤖 Generated with Claude Code