Repository navigation
Conversation
A zero-sized per-repository semaphore can never grant a permit, so a valid-looking configuration caused every Git request for a repository to wait indefinitely. Require `server.max_concurrent_per_repo` to be positive and add a regression test for the invalid zero value. ✅ `cargo test -p walgit-config zero_per_repo_concurrency_is_rejected` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` Closes tobi#79 (cherry picked from commit 77ade75)
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16.
Imports tobi/walgit#87 by @behinddwalls, unchanged. A per-repository concurrency of 0 made every git request for a repository wait forever; it is now a config error.
Verified on the top of this stack:
cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --check, the crate test suites, and the Azure harness (just test-azure: store contract plus git push, clone, pull and cold restart on Azurite) pass. Known unrelated failures: the runtime stall timing tests ine2e(also intermittent on main) and the web UI asset tests that needpnpm run build.