Repository navigation
Conversation
Backend SDK retries covered conditional mutations as well as reads. If a manifest CAS landed but its response was lost, an SDK retry could receive 412 from the already-committed write and make the publisher treat success as a lost race. Apply `store.max_retries` only to idempotent GCS and S3 reads and interrupted bulk reads. Configure GCS mutation clients and the S3 mutation client for one attempt, while S3 metadata reads use a separate retry-enabled client and presigned GETs retain explicit bounded retries. Healthy calls remain one request. Failure paths add at most `store.max_retries` read attempts; conditional writes, uploads, copies, multipart operations, and deletes remain single-attempt. ✅ `cargo check -p walgit-store --all-features` ✅ `cargo test -p walgit-store --all-features` ✅ `cargo test -p walgit-server --test sim healthy_request_round_trip_budgets -- --exact` ✅ `cargo clippy -p walgit-store --all-targets --all-features -- -D warnings` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` Closes tobi#82 (cherry picked from commit 34f240d)
The retry budget now means the same on every backend: extra attempts for transient failures on reads, zero disables them. Conditional writes stay single-attempt.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14.
Imports tobi/walgit#90 by @behinddwalls.
store.max_retriesapplies only to idempotent reads; S3 and GCS mutation clients make one attempt.Conflict resolution: tobi#60 (in this stack) and tobi#90 both rewrote the S3 client setup. The credentials provider from tobi#60 (static pair or default chain) is resolved once and shared by the single-attempt mutation client and the retrying read client from tobi#90.
One follow-up commit makes Azure reads follow
store.max_retriestoo, so the setting means the same on every backend; Azure conditional writes stay single-attempt.Verified on the top of this stack:
cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --check, the crate test suites, and the Azure harness (just test-azure: store contract plus git push, clone, pull and cold restart on Azurite) pass. Known unrelated failures: the runtime stall timing tests ine2e(also intermittent on main) and the web UI asset tests that needpnpm run build.