Skip to content

fix(betting): prevent events from exposing failed transactions - #171

Merged
dultimateade merged 1 commit into
dultimateade:mainfrom
thelight08:fix/issue-20
Sep 29, 2026
Merged

dultimateade merged 1 commit into
dultimateade:mainfrom
thelight08:fix/issue-20

Conversation

@thelight08

Copy link
Copy Markdown

Summary

  • defer single-bet event publication until the final accounting snapshot completes
  • queue batch bet events until every bet and the idempotency guard have committed
  • repair the duplicated workspace entries in Cargo.lock so Cargo can validate the workspace

Validation

  • git diff --check
  • focused predictify-hybrid test build started; the workspace compile is lengthy

Closes #20

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@thelight08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@thelight08

Copy link
Copy Markdown
Author

@dultimateade Issue #20 is implemented and pushed. Bet events are deferred until the complete transaction path succeeds, including the batch idempotency guard, so failed/auth-rejected calls cannot expose misleading events. The PR includes Closes #20; please review the security behavior and the Cargo.lock repair.

@dultimateade
dultimateade merged commit 0a84cc5 into dultimateade:main Sep 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#020][security] Issue #020

3 participants